Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]Add RGB matrix to reference_info_json.md #20462

Closed
wants to merge 1 commit into from
Closed

[Docs]Add RGB matrix to reference_info_json.md #20462

wants to merge 1 commit into from

Conversation

peepeetee
Copy link
Contributor

I think I touched something in rgb lighting to fix a link, I can take that out if needed

is there anything here that does

RGB_MATRIX_FRAMEBUFFER_EFFECTS
RGB_MATRIX_KEYPRESSES
RGB_MATRIX_KEYRELEASES

?
does it just need the effects enabled and done in the translation?

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Add RGB matrix to reference_info_json.md
384ab1b 
I think I touched something in rgb lighting to fix a link, I can take that out if needed

is there anything here that does 

RGB_MATRIX_FRAMEBUFFER_EFFECTS
RGB_MATRIX_KEYPRESSES
RGB_MATRIX_KEYRELEASES

?
does it just need the effects enabled and done in the translation?
@adophoxia
Copy link
Contributor

is there anything here that does
RGB_MATRIX_FRAMEBUFFER_EFFECTS
RGB_MATRIX_KEYPRESSES
RGB_MATRIX_KEYRELEASES
?

There isn't a info.json equivalent for these three #defines since they don't follow the "effects" stuff as they're technically not actual effects and more so toggles (From how I see it). I tried to do something like this before myself and it didn't work the way I intended it to, which required me to still have them be defined in config.h.

@drashna drashna requested a review from a team April 17, 2023 02:39
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 20, 2023
@fauxpark
Copy link
Member

Superseded by #21324

@fauxpark fauxpark closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peepeetee @adophoxia @fauxpark